On Wed, Dec 23, 2015 at 12:50:20PM +0100, Paul Kocialkowski wrote: > Le mercredi 23 décembre 2015 à 11:41 +0000, Mark Brown a écrit :
> > I would expect the driver at least needs to know how the pins or > > strapped, or otherwise have configuration for ignoring the input on the > > pins. This just deletes the warnings, it doesn't have any handling for > > this case that I can see. > When the DVS GPIO is invalid, lp872x_init_dvs jumps to the > set_default_dvs_mode label, which instructs the chip not to use the DVS > pin at all and do it all in software instead (by clearing the > LP8720_EXT_DVS_M bit in the LP872X_GENERAL_CFG register). > That is reflected later in the code, when setting the bucks (the DVS pin > only applies to the bucks) by checking for the LP8720_EXT_DVS_M bit on > the LP872X_GENERAL_CFG register (in lp872x_select_buck_vout_addr) to > decide whether to use software or hardware DVS selection. > As far as I understood, everything goes well when the GPIO is invalid. So please put this analysis in the changelog so that the changelog accurately reflects what the change is doing.
Description: PGP signature