Hi,
* Hiremath, Vaibhav <[email protected]> [091119 20:19]:
>
> > -----Original Message-----
> > From: [email protected] [mailto:linux-omap-
> > [email protected]] On Behalf Of Gregoire Gentil
> > Sent: Thursday, November 19, 2009 10:48 PM
> > To: [email protected]
> > Cc: Gregoire Gentil; Tony Lindgren; Tim Yamin
> > Subject: [PATCH 2/8] Board file of Always Innovating OMAP3-based
> > Touch Book
> >
> >
> > Signed-off-by: Gregoire Gentil <[email protected]>
> > ---
> > arch/arm/mach-omap2/board-omap3touchbook.c | 683
> > ++++++++++++++++++++++++++++
> > 1 files changed, 683 insertions(+), 0 deletions(-)
> > create mode 100644 arch/arm/mach-omap2/board-omap3touchbook.c
> >
> > diff --git a/arch/arm/mach-omap2/board-omap3touchbook.c
> > b/arch/arm/mach-omap2/board-omap3touchbook.c
> > new file mode 100644
> > index 0000000..ad3ef6e
> > --- /dev/null
> > +++ b/arch/arm/mach-omap2/board-omap3touchbook.c
<snip>
> > +static int touchbook_backlight_brightness = 50;
> > +static struct omap_dm_timer *touchbook_backlight_pwm;
> > +
> > +static int touchbook_backlight_read(struct backlight_device *bd)
> > +{
> > + return touchbook_backlight_brightness;
> > +}
> > +
> > +static int touchbook_backlight_update(struct backlight_device *bd)
> > +{
> > + int value = bd->props.brightness;
> > + touchbook_backlight_brightness = value;
> > +
> [Hiremath, Vaibhav] I think we can get rid of variable "value" here. You can
> directly initialize it to "touchbook_backlight_brightness".
>
> One more thing just came in my mind, have you thought of using standard
> backlight class driver???
I'll add this without the backlight code so we get the basic
support into mainline while using the backlight class driver
issue is being discussed.
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
