> -----Original Message-----
> From: Tony Lindgren [mailto:[email protected]]
> Sent: Tuesday, December 08, 2009 4:49 AM
> To: Tim Yamin
> Cc: Hiremath, Vaibhav; Gregoire Gentil; [email protected]
> Subject: Re: [PATCH 2/8] Board file of Always Innovating OMAP3-based
> Touch Book
>
> * Tim Yamin <[email protected]> [091207 14:10]:
> > 2009/12/7 Tony Lindgren <[email protected]>:
> > >> One more thing just came in my mind, have you thought of using
> standard backlight class driver???
> > >
> > > I'll add this without the backlight code so we get the basic
> > > support into mainline while using the backlight class driver
> > > issue is being discussed.
> >
> > But the board file *is* implementing the standard backlight class,
> > i.e. the interface in linux/backlight.h... perhaps I'm
> > misunderstanding the intention here?
>
> Hmm, yeah. Hiremath care to clarify what you had in mind
> with that standard backlight class driver comment?
>
[Hiremath, Vaibhav] I was referring to generic_bl driver? Actually when I had
submitted the similar patch for OMAP3EVM, I had received similar comment to use
generic_bl interface.
In your case, you just need to do something -
static void touchbook_set_backlight(int intensity)
{
....
}
static struct generic_bl_info touchbook_bl_platform_data = {
.name = " touchbook-bklight",
.max_intensity = 100,
.default_intensity = 50,
.limit_mask = 0,
.set_bl_intensity = touchbook_set_backlight,
.kick_battery = NULL,
};
static struct platform_device touchbook_bklight_device = {
.name = "generic-bl",
.id = -1,
.dev = {
.platform_data = & touchbook_bl_platform_data,
},
};
Thanks,
Vaibhav
> Regards,
>
> Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html