Hi Nishanth, >From: Dasgupta, Romit > >Menon, Nishanth wrote: >> We had removed the frequency for OPP1 L3 when we used to use frequency >> to enable/disable frequencies. It is better to populate the same >> instead of confusing future readers of the code. The OPP1 remains >> disabled as explained in the discussion. > >IMHO the best way to unconfuse readers is to remove the entry.
The confusion is due to a mismatch between public TRM/white paper and current code, so maybe a simple comment on top of the omap34xx_l3_rate_table will be enough. Regards, Benoit >> >> Discussion: http://marc.info/?t=126453821900001&r=1&w=2 >> >> Cc: Andrew Murray <[email protected]> >> Cc: Benoit Cousson <[email protected]> >> Cc: Kevin Hilman <[email protected]> >> >> Signed-off-by: Nishanth Menon <[email protected]> >> --- >> arch/arm/mach-omap2/cpufreq34xx.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/cpufreq34xx.c b/arch/arm/mach- >omap2/cpufreq34xx.c >> index 209af2b..aec1ffe 100644 >> --- a/arch/arm/mach-omap2/cpufreq34xx.c >> +++ b/arch/arm/mach-omap2/cpufreq34xx.c >> @@ -43,7 +43,7 @@ static struct omap_opp_def __initdata >omap34xx_mpu_rate_table[] = { >> >> static struct omap_opp_def __initdata omap34xx_l3_rate_table[] = { >> /* OPP1 */ >> - OMAP_OPP_DEF(false, 0, 975000), >> + OMAP_OPP_DEF(false, 41500000, 975000), >> /* OPP2 */ >> OMAP_OPP_DEF(true, 83000000, 1050000), >> /* OPP3 */ Texas Instruments France SA, 821 Avenue Jack Kilby, 06270 Villeneuve Loubet. 036 420 040 R.C.S Antibes. Capital de EUR 753.920 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
