Hi,
> > +#ifdef CONFIG_USB_MUSB_OTG
> > + .mode
> > = MUSB_OTG,
> > +#elif defined(CONFIG_USB_MUSB_HDRC_HCD)
> > + .mode
> > = MUSB_HOST,
> > +#elif defined(CONFIG_USB_GADGET_MUSB_HDRC)
> > .mode
> > = MUSB_PERIPHERAL,
> > +#endif
>
> > = MUSB_PERIPHERAL,
> > +#endif
>
> By the way ... the #ifdeffery should indeed vanish from all board
> configs except the Davinci DM6446 EVM.
If we are claiming to support:
A. Same kernel would work on multiple boards
B. Single kernel for one single board
Then I think these #ifdefferys are required in all the board files.
Let's consider the OMAP3EVM which supports all the three modes and
If these #ifdefferys are not present and .mode is set to OTG.
Then if I choose to compile the Kernel only for peripheral mode
(Case-B above) then I would get below error from musb_core.c.
"incompatible Kconfig role setting"
-Ajay
> That board is kind of quirky
> in terms of USB support, and needs jumpering to get host or peripheral
> mode (and can't do OTG). I suspect some of the other boards did a bad
> thing and tried emulating what that board did.
>
> But the description for such a patch would emphasize removing bogus
> ifdeffery, to match the board hardware (which is not conditional but
> is instead fixed).
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
