"Lesly Arackal Manuel" <[email protected]> writes: >> > @@ -510,18 +502,6 @@ void omap_sram_idle(void) >> > } >> > omap_uart_resume_idle(0); >> > omap_uart_resume_idle(1); >> > - if (core_next_state == PWRDM_POWER_OFF) { >> > - u32 voltctrl = OMAP3430_AUTO_OFF; >> > - >> > - if (voltage_off_while_idle) >> > - voltctrl |= OMAP3430_SEL_OFF; >> > - prm_clear_mod_reg_bits(voltctrl, >> > - OMAP3430_GR_MOD, >> > - OMAP3_PRM_VOLTCTRL_OFFSET); >> > - } else if (core_next_state == PWRDM_POWER_RET) >> > - prm_clear_mod_reg_bits(OMAP3430_AUTO_RET, >> > - OMAP3430_GR_MOD, >> > - OMAP3_PRM_VOLTCTRL_OFFSET); >> >> ...in the resume path, this entire part is removed, but with >> replacement call into the voltage layer. This needs to be well >> documented in the changelog as to why this is not needed. > > The comment for removing this part is already there in the changelog: > **** >> > Also removed the clearing of PRM_VOLTCTRL register bits, because this >> will be >> > used only when it goes to low power mode next time. > **** > > OK, I will add more detail in next ver.
Yes please, that description is not clear. Thanks, Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
