On Thu, 17 Jun 2010 20:56:58 +0530 (IST)
"kishore kadiyala" <[email protected]> wrote:
> --- a/arch/arm/plat-omap/include/plat/mmc.h
> +++ b/arch/arm/plat-omap/include/plat/mmc.h
> @@ -43,6 +43,9 @@
>
> #define OMAP_MMC_MAX_SLOTS 2
>
> +#define NON_GPIO 0
> +#define GPIO 1
I'm counting about seven different definitions of "GPIO" in the kernel
already.
drivers/hwmon/it87.c:
#define GPIO 0x07
drivers/media/dvb/dvb-usb/ec168.h:
GPIO = 0x04,
drivers/net/hamachi.c:
GPIO=0x6E
drivers/staging/rtl8187se/r8180_hw.h:
#define GPIO 0x91
etcetera. It's a crazy identifier to use in a header file, and
the chances of a miscompile-causing collision are increasing.
enum cd_type {
CD_TYPE_NON_GPIO = 0,
CD_TYPE_GPIO = 1,
};
perhaps?
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
