More misc cleanups for Sr branch including print cleans, checks etc. This series probably should be squashed with other patches in pm-sr branch. note some of these patches address few other comments I had made in an unrelated patch.
Related comments prior to providing patches: a) I looked close into sr_device.c, I dont think we should decide in sr_device.c if SR is enabled by default or not. IMHO, this should be passed on from board files. it is not the sr_device's call to make. we have boards which are comfortable with SR and which are not. example some boards may choose to enable SR late in the game, while some may choose to enable it by default. we need to cater to both. e.g. currently 3430 es3.1 would have SR enabled by default. N900 as an example chooses to allow users to decide what to have and is enabled late in the game (boots up disabled, gets enabled once userspace starts). b) It assumes that 3630 have ntargets - this is true from ES1.1 onwards. the older silicon dont have ntargets fused in them. How do we want to handle these? This is the second series independent of series 1: http://marc.info/?l=linux-omap&m=127741497415352&w=2 Nishanth Menon (7): omap3: voltage: cleanup pr_xxxx omap3: sr: cleanup pr_xxx omap3: sr: enable/disable sr only if required omap3: sr: device: cleanup pr_xxx omap3: sr: device: add unlikely checks omap3: sr: device: check for dev_attr omap3: sr: device: fail sr_dev_init should return error arch/arm/mach-omap2/smartreflex.c | 24 ++++++++++++++++++------ arch/arm/mach-omap2/sr_device.c | 29 +++++++++++++++++++---------- arch/arm/mach-omap2/voltage.c | 7 ++++--- 3 files changed, 41 insertions(+), 19 deletions(-) Regards, Nishanth Menon Cc: Kevin Hilman <[email protected]> Cc: Thara Gopinath <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
