sr_dev_init should return error on error conditions

Cc: Kevin Hilman <[email protected]>
Cc: Thara Gopinath <[email protected]>

Signed-off-by: Nishanth Menon <[email protected]>
---
 arch/arm/mach-omap2/sr_device.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/sr_device.c b/arch/arm/mach-omap2/sr_device.c
index 81d2532..945ff45 100644
--- a/arch/arm/mach-omap2/sr_device.c
+++ b/arch/arm/mach-omap2/sr_device.c
@@ -163,7 +163,7 @@ static int sr_dev_init(struct omap_hwmod *oh, void *user)
                                __func__, i + 1);
                i++;
                kfree(sr_data);
-               return 0;
+               return -ENODATA;
        }
        sr_set_nvalues(sr_dev_data, sr_data);
        od = omap_device_build(name, i, oh, sr_data, sizeof(*sr_data),
@@ -173,6 +173,7 @@ static int sr_dev_init(struct omap_hwmod *oh, void *user)
                pr_warning("%s: Could not build omap_device for %s: %s.\n\n",
                        __func__, name, oh->name);
                kfree(sr_data);
+               return PTR_ERR(od);
        }
        i++;
        return 0;
-- 
1.6.3.3

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to