> -----Original Message-----
> From: Russell King - ARM Linux [mailto:[email protected]]
> Sent: Saturday, September 04, 2010 4:35 PM
> To: Shilimkar, Santosh
> Cc: Tony Lindgren; [email protected]; linux-arm-
> [email protected]; Bryan Wu; Will Deacon
> Subject: Re: [PATCH 6/6] omap: Fix SMP on UP interrupt handling for multi-
> omap
>
> On Fri, Sep 03, 2010 at 05:36:27PM +0530, Shilimkar, Santosh wrote:
> > > -----Original Message-----
> > > From: [email protected] [mailto:linux-omap-
> > > [email protected]] On Behalf Of Tony Lindgren
> > > Sent: Thursday, September 02, 2010 9:54 PM
> > > To: Russell King - ARM Linux
> > > Cc: [email protected]; [email protected];
> > > Bryan Wu; Will Deacon
> > > Subject: [PATCH 6/6] omap: Fix SMP on UP interrupt handling for multi-
> omap
> > >
> > > From c04a57fc3b41d886f56ccdc27cf9758de0c95202 Mon Sep 17 00:00:00 2001
> > > From: Tony Lindgren <[email protected]>
> > > Date: Tue, 17 Aug 2010 13:33:23 +0300
> > > Subject: [PATCH 6/6] omap: Fix SMP on UP interrupt handling for multi-
> omap
> > >
> > > Fix SMP on UP interrupt handling for multi-omap
> > >
> > > Signed-off-by: Tony Lindgren <[email protected]>
> > > ---
> > > arch/arm/mach-omap2/omap-smp.c | 13 +++++++++----
> > > arch/arm/mach-omap2/timer-gp.c | 7 +++++--
> > > 2 files changed, 14 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/arch/arm/mach-omap2/omap-smp.c b/arch/arm/mach-
> omap2/omap-
> > > smp.c
> > > index 9e9f70e..a8bb49c 100644
> > > --- a/arch/arm/mach-omap2/omap-smp.c
> > > +++ b/arch/arm/mach-omap2/omap-smp.c
> > > @@ -22,6 +22,7 @@
> > >
> > > #include <asm/cacheflush.h>
> > > #include <asm/localtimer.h>
> > > +#include <asm/smp_plat.h>
> > > #include <asm/smp_scu.h>
> > > #include <mach/hardware.h>
> > > #include <mach/omap4-common.h>
> > > @@ -114,11 +115,15 @@ void __init smp_init_cpus(void)
> > > {
> > > unsigned int i, ncores;
> > >
> > > - /* Never released */
> > > - scu_base = ioremap(OMAP44XX_SCU_BASE, SZ_256);
> > > - BUG_ON(!scu_base);
> > > + if (smp_on_up()) {
> > > + ncores = 1;
> > I am not sure if this is the correct approach. The SCU
> > hardware is not present other than OMAP4. So we should
> > just return here when the silicon is not omap4.
> > if (!cpu_is_omap44xx())
> > return -ENODEV;
>
> void function returning a value? Just a simple return statement will do.
Oh yes.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
