Actually check for errors: print an error log and return NULL.

Signed-off-by: Aaro Koskinen <[email protected]>
---
 arch/arm/mach-omap2/sdram-nokia.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-omap2/sdram-nokia.c 
b/arch/arm/mach-omap2/sdram-nokia.c
index 1171451..863586b 100644
--- a/arch/arm/mach-omap2/sdram-nokia.c
+++ b/arch/arm/mach-omap2/sdram-nokia.c
@@ -223,10 +223,14 @@ struct omap_sdrc_params *nokia_get_sdram_timings(void)
        int err = 0;
        int i;
 
-       for (i = 0; i < ARRAY_SIZE(nokia_timings); i++)
+       for (i = 0; i < ARRAY_SIZE(nokia_timings); i++) {
                err |= sdrc_timings(i, nokia_timings[i].rate,
                                       nokia_timings[i].data);
+               if (err)
+                       pr_err("%s: error with rate %ld: %d\n", __func__,
+                              nokia_timings[i].rate, err);
+       }
 
-       return &nokia_sdrc_params[0];
+       return err ? NULL : nokia_sdrc_params;
 }
 
-- 
1.5.6.5

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to