Hi Aaro, A couple of small comments below, otherwise looks nice to me.
Jamie On Thu, Dec 09, 2010 at 06:39:24PM +0200, Aaro Koskinen wrote: > Add minimal support for Nokia RM-680 board. > > Tested with omap2plus_defconfig. > > Signed-off-by: Aaro Koskinen <[email protected]> > --- [...] > +#if defined(CONFIG_MTD_ONENAND_OMAP2) || \ > + defined(CONFIG_MTD_ONENAND_OMAP2_MODULE) > +static struct omap_onenand_platform_data board_onenand_data[] = { > + { > + .gpio_irq = 65, > + .flags = ONENAND_SYNC_READWRITE, > + } > +}; > +#endif > + > +/* eMMC */ > +static struct omap2_hsmmc_info mmc[] __initdata = { > + { > + .name = "internal", > + .mmc = 2, > + .caps = MMC_CAP_4_BIT_DATA | MMC_CAP_MMC_HIGHSPEED, > + .gpio_cd = -EINVAL, > + .gpio_wp = -EINVAL, > + }, > + { /* Terminator */ } > +}; > + > +static void __init rm680_peripherals_init(void) > +{ > + platform_add_devices(rm680_peripherals_devices, > + ARRAY_SIZE(rm680_peripherals_devices)); > + rm680_i2c_init(); > + gpmc_onenand_init(board_onenand_data); What happens if CONFIG_MTD_ONENAND_OMAP2=n and CONFIG_MTD_ONENAND_OMAP2_MODULE=n? Do you need to define board_onenand_data to NULL if these aren't enabled? > + omap2_hsmmc_init(mmc); > +} > + > +static void __init rm680_init_irq(void) > +{ > + struct omap_sdrc_params *sdrc_params; > + > + sdrc_params = nokia_get_sdram_timings(); > + omap2_init_common_hw(sdrc_params, sdrc_params); > + omap_init_irq(); > + omap_gpio_init(); > +} > + > +#ifdef CONFIG_OMAP_MUX > +static struct omap_board_mux board_mux[] __initdata = { > + { .reg_offset = OMAP_MUX_TERMINATOR }, > +}; > +#endif > + > +static struct omap_musb_board_data rm680_musb_data = { > + .interface_type = MUSB_INTERFACE_ULPI, > + .mode = MUSB_PERIPHERAL, > + .power = 100, > +}; > + > +static void __init rm680_init(void) > +{ > + omap3_mux_init(board_mux, OMAP_PACKAGE_CBB); The same here as with the onenand data. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
