> -----Original Message-----
> From: [email protected] [mailto:linux-omap-
> [email protected]] On Behalf Of Tony Lindgren
> Sent: Tuesday, March 29, 2011 3:51 AM
> To: [email protected]
> Cc: [email protected]
> Subject: [PATCH 01/10] omap: Use separate init_irq functions to
> avoidcpu_is_omap tests early
>
> This allows us to remove cpu_is_omap calls from init_irq functions
> and the irq handler. There should not be any need for cpu_is_omap
> as at this point we only care about SoC generation, and not about
> subcategories.
>
> The main reason for the patch is that we want to initialize only
> minimal omap specific code from the init_early call, and this and
> the following patches get us closer to that goal.
>
> Signed-off-by: Tony Lindgren <[email protected]>
> ---
[....]
> diff --git a/arch/arm/mach-omap2/omap4-common.c b/arch/arm/mach-
> omap2/omap4-common.c
> index 9ef8c29..1c3bcf1 100644
> --- a/arch/arm/mach-omap2/omap4-common.c
> +++ b/arch/arm/mach-omap2/omap4-common.c
> @@ -19,6 +19,8 @@
> #include <asm/hardware/gic.h>
> #include <asm/hardware/cache-l2x0.h>
>
> +#include <plat/irqs.h>
> +
> #include <mach/hardware.h>
> #include <mach/omap4-common.h>
>
> @@ -34,6 +36,10 @@ void __init gic_init_irq(void)
> void __iomem *gic_cpu_base;
>
> /* Static mapping, never released */
> + omap_irq_base = ioremap(OMAP44XX_GIC_CPU_BASE, SZ_4K);
> + BUG_ON(!omap_irq_base);
> +
Above mapping is incorrect. The address space is of just
512 bytes. Infact you don't need to ioremap it again.
Below should be enough.
diff --git a/arch/arm/mach-omap2/omap4-common.c
b/arch/arm/mach-omap2/omap4-common.c
index 9ef8c29..9bddc9e 100644
--- a/arch/arm/mach-omap2/omap4-common.c
+++ b/arch/arm/mach-omap2/omap4-common.c
@@ -41,6 +41,8 @@ void __init gic_init_irq(void)
gic_cpu_base = ioremap(OMAP44XX_GIC_CPU_BASE, SZ_512);
BUG_ON(!gic_cpu_base);
+ omap_irq_base = gic_cpu_base;
+
gic_init(0, 29, gic_dist_base_addr, gic_cpu_base);
}
Regards,
Santosh
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
