On Tue, 2011-05-10 at 15:47 +0200, Mark Brown wrote:
> On Tue, May 10, 2011 at 03:30:52PM +0300, Tomi Valkeinen wrote:
>
> > This sounds just the thing we need here. Do you think there's a chance
> > the code could get merged in the next window? And I'm also happy to test
> > the code with omapdss, whenever you have something ready.
>
> Patch is below, tested with my "hey look, this compiles!" test plan -
> I'd be a bit surprised if it ran straight off.
So how should the regulator be set up?
If we currently have in the board file:
static struct regulator_consumer_supply sdp4430_vcxio_supply[] = {
REGULATOR_SUPPLY("vdds_dsi", "omapdss_dss"),
REGULATOR_SUPPLY("vdds_dsi", "omapdss_dsi.0"),
REGULATOR_SUPPLY("vdds_dsi", "omapdss_dsi.1"),
};
static struct regulator_init_data sdp4430_vcxio = {
.constraints = {
...
},
.num_consumer_supplies = ARRAY_SIZE(sdp4430_vcxio_supply),
.consumer_supplies = sdp4430_vcxio_supply,
};
I should setup a fixed regulator, which is supplied from VCXIO, and
omapdss will get its powers from this fixed regulator?
So, in the common display file:
static struct regulator_consumer_supply fixed_supply[] = {
REGULATOR_SUPPLY("vdds_dsi", "omapdss_dss"),
REGULATOR_SUPPLY("vdds_dsi", "omapdss_dsi.0"),
REGULATOR_SUPPLY("vdds_dsi", "omapdss_dsi.1"),
};
static struct regulator_init_data fixed_reg_init_data = {
.constraints = {
...
},
.num_consumer_supplies = ARRAY_SIZE(fixed_supply),
.consumer_supplies = fixed_supply,
};
static struct fixed_voltage_config omap_dss_fixed_reg_data = {
.supply_name = "what should this be?",
.init_data = &fixed_reg_init_data,
};
static struct platform_device omap_dss_fixed_reg_device = {
.name = "reg-fixed-voltage",
.id = 0,
.dev = {
.platform_data = &omap_dss_fixed_reg_data,
},
};
And in the board file:
static struct regulator_consumer_supply sdp4430_vcxio_supply[] = {
REGULATOR_SUPPLY("what should this be?", "reg-fixed-voltage.0"),
};
static struct regulator_init_data sdp4430_vcxio = {
.constraints = {
...
},
.num_consumer_supplies = ARRAY_SIZE(sdp4430_vcxio_supply),
.consumer_supplies = sdp4430_vcxio_supply,
};
If so, it's again slightly difficult. I want to do the common display
stuff in a one place, used by all the boards. If I setup the fixed
regulator in the common file, I need to give it an id which may conflict
with a possible fixed regulator set up in the board file.
Or am I totally on the wrong track here =)?
Tomi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
