* Kevin Hilman <[email protected]> [110623 10:02]:
> Tony Lindgren <[email protected]> writes:
> 
> > This patch makes timer-gp.c to use only a subset of dmtimer
> > functions without the need to initialize dmtimer code early.
> >
> > Also note that now with the inline functions, timer_set_next_event
> > becomes more efficient in the lines of assembly code.
> >
> > Signed-off-by: Tony Lindgren <[email protected]>
> > Reviewed-by: Kevin Hilman <[email protected]>
> 
> In order for this to work, *all* the dmtimer functions need to be
> converted.  Some still call the real driver, which may not yet be
> initialized (as pointed out for [7/10]...

Well omap_dm_timer_init_one is a static omap2plus specific
implementation that can then be then passed as a function pointer
to the dmtimer device driver in later patches.
 
> >     gptimer = omap_dm_timer_request_specific(gptimer_id);
> 
> Here remains a call to the real driver, which is not yet initialized
> when called from sys_timer.init.

There's no need for omap_dm_timer_request_specific after the later
patches. It gets removed in the PM_DEBUG sysfs interface removal patch.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to