On Sat, 2011-07-09 at 12:56 +0200, Mark Brown wrote: > On Sat, Jul 09, 2011 at 01:40:08PM +0300, Felipe Balbi wrote: > > > a hack for a hack... what's the difference ? If it's only to solve a > > limitation temporarily anyways... although it would be better to discuss > > how to add such support to the framework already. > > I'm completely unable to identify an issue in the framework that this > patch addresses - the API already supports multiple devices supplying > regulators, it's extremely difficult to understand what motivates the > change.
Hi, So if I understood the comments right, what you are saying is that I should probably implement a new regulator subset for the twl-regulator. I.e. we have currently TWL4030_ADJUSTABLE_LDO etc., so I could add a TWL4030_ADJUSTABLE_SMPS for example. These regulators would then use the appropriate interface according to board specific setup. How would you propose to use / register the alternate ops to access the omap_voltage layer from here though for set/get voltage? The main thing is that VDD1 and VDD2 regulators in TWL4030 can be controlled through the typical TWL control interface (I2C), like the rest of the TWL regulators, or it can be controlled through the voltage processor interface which uses a dedicated I2C bus and is not accessible to anything but the voltage processor. The used interface can be configured from the TWL side. The voltage processor support is currently provided by the omap platform code, and regulator code knows nothing about this. It might also be possible to do compile time switch for the interface here if that is acceptable, however a runtime interface for doing this would provide more flexibility. I'll also contact Graeme and check what he is doing on this front. -Tero Texas Instruments Oy, Tekniikantie 12, 02150 Espoo. Y-tunnus: 0115040-6. Kotipaikka: Helsinki -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
