On Fri, Sep 23, 2011 at 10:48 AM, Paul Walmsley <[email protected]> wrote:
> On Thu, 22 Sep 2011, Keerthy wrote:
>
>> div_ts_ck feeds only the temperature sensor functional clock
>> and also has a clksel associated (for divider selection). Mapping this
>> as well as the bandgap_ts_fclk the fclk of temperature sensor in clkdev
>> table,
>> so a clk_set_rate() on the div_ts_ck in the driver would have the effect of
>> changing the temperature sensor clock rate indirectly.
>>
>> Signed-off-by: Keerthy <[email protected]>
>> Reviewed-by: Rajendra Nayak <[email protected]>
>> Cc: [email protected]
>> Cc: [email protected]
>
> Your cc's didn't take effect...
Yes :(. I mistakenly had supress cc in my git send command.
>
>> ---
>> arch/arm/mach-omap2/clock44xx_data.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/clock44xx_data.c
>> b/arch/arm/mach-omap2/clock44xx_data.c
>> index 946bf04..c51e513 100644
>> --- a/arch/arm/mach-omap2/clock44xx_data.c
>> +++ b/arch/arm/mach-omap2/clock44xx_data.c
>> @@ -3185,9 +3185,9 @@ static struct omap_clk omap44xx_clks[] = {
>> CLK(NULL, "aes2_fck", &aes2_fck,
>> CK_443X),
>> CLK(NULL, "aess_fck", &aess_fck,
>> CK_443X),
>> CLK(NULL, "bandgap_fclk", &bandgap_fclk,
>> CK_443X),
>> - CLK(NULL, "bandgap_ts_fclk", &bandgap_ts_fclk,
>> CK_446X),
>> + CLK("omap4460plus_scm.0", "fck", &bandgap_ts_fclk,
>> CK_446X),
>> CLK(NULL, "des3des_fck", &des3des_fck,
>> CK_443X),
>> - CLK(NULL, "div_ts_ck", &div_ts_ck,
>> CK_446X),
>> + CLK("omap4460plus_scm.0", "div_ck",
>> &div_ts_ck, CK_446X),
>
> Clearly this device is incorrectly named. You're setting up a clkdev
> entry that's marked as being valid for OMAP4430, but your device is called
> "omap4460plus_scm". They can't both be right...
This is addressed in Patch 06.
>
>
>> CLK(NULL, "dmic_sync_mux_ck", &dmic_sync_mux_ck,
>> CK_443X),
>> CLK(NULL, "dmic_fck", &dmic_fck,
>> CK_443X),
>> CLK(NULL, "dsp_fck", &dsp_fck,
>> CK_443X),
>> --
>> 1.7.0.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>> the body of a message to [email protected]
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
>
> - Paul
>
--
Regards and Thanks,
Keerthy
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
