On Mon, Jan 30, 2012 at 3:13 PM, Paul Walmsley <[email protected]> wrote:
> Remove some superfluous calls to pwrdm_clear_all_prev_pwrst().
> pwrdm_pre_transition(), which appears a few lines after these calls,
> invokes pwrdm_clear_all_prev_pwrst() on each powerdomain -- there's no
> need to do it twice.
>
> N.B.: some of us have observed that accesses to the previous
> powerstate registers seem to be quite slow. Although the writes
> removed by this patch should be buffered by the write buffer, there is
> a read to a PRM register immediately afterwards. That will block the
> OMAP3 MPU until all of those writes complete. So this patch should
> result in a minor performance improvement during idle entry.
>
> Signed-off-by: Paul Walmsley <[email protected]>
> Cc: Kevin Hilman <[email protected]>
> Cc: Rajendra Nayak <[email protected]>
> Cc: Santosh Shilimkar <[email protected]>
> Cc: Tero Kristo <[email protected]>
> ---
Nice clean-up
Acked-by: Santosh Shilimkar <[email protected]>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
