Simplify:
        - set ECB
        ...
        - LCR mode A
        - clear TCRTLR
        - LCR mode B
        - clear ECB
        - set ECB and update other bits
        - LCR mode A
        - update XONANY

to:
        - set ECB
        ...
        - LCR mode B
        - set ECB and update other bits
        - LCR mode A
        - update XONANY and clear TCRTLR

Signed-off-by: Russell King <[email protected]>
---
 drivers/tty/serial/omap-serial.c |   11 +++--------
 1 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index e786eac..b497187 100644
--- a/drivers/tty/serial/omap-serial.c
+++ b/drivers/tty/serial/omap-serial.c
@@ -896,11 +896,6 @@ serial_omap_set_termios(struct uart_port *port, struct 
ktermios *termios,
                up->efr &= ~(UART_EFR_CTS | UART_EFR_RTS);
        }
 
-       /* Disable access to TCR/TLR */
-       serial_out(up, UART_MCR, up->mcr);
-       serial_out(up, UART_LCR, UART_LCR_CONF_MODE_B);
-       serial_out(up, UART_EFR, up->efr);
-
        /* clear SW control mode bits */
        up->efr &= OMAP_UART_SW_CLR;
 
@@ -920,9 +915,6 @@ serial_omap_set_termios(struct uart_port *port, struct 
ktermios *termios,
        if (termios->c_iflag & IXOFF)
                up->efr |= OMAP_UART_SW_TX;
 
-       serial_out(up, UART_EFR, up->efr | UART_EFR_ECB);
-       serial_out(up, UART_LCR, UART_LCR_CONF_MODE_A);
-
        /*
         * IXANY Flag:
         * Enable any character to restart output.
@@ -934,6 +926,9 @@ serial_omap_set_termios(struct uart_port *port, struct 
ktermios *termios,
        else
                up->mcr &= ~UART_MCR_XONANY;
 
+       serial_out(up, UART_LCR, UART_LCR_CONF_MODE_B);
+       serial_out(up, UART_EFR, up->efr | UART_EFR_ECB);
+       serial_out(up, UART_LCR, UART_LCR_CONF_MODE_A);
        serial_out(up, UART_MCR, up->mcr);
        serial_out(up, UART_LCR, UART_LCR_CONF_MODE_B);
        serial_out(up, UART_EFR, up->efr);
-- 
1.7.4.4

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to