On 2013-03-11 08:21, Archit Taneja wrote: > Hi, > > On Friday 08 March 2013 05:21 PM, Tomi Valkeinen wrote: >> Taal panel driver has support to set rotation and mirroring. However, >> these features cannot be used without causing tearing, and are never >> used. The code is just extra bloat, so let's remove it. >> >> Signed-off-by: Tomi Valkeinen <tomi.valkei...@ti.com> > > <snip> >> static ssize_t taal_num_errors_show(struct device *dev, >> @@ -1025,10 +973,6 @@ static int taal_power_on(struct omap_dss_device >> *dssdev) >> if (r) >> goto err; >> >> - r = taal_set_addr_mode(td, td->rotate, td->mirror); >> - if (r) >> - goto err; >> - > > I'm curious if we need to set the address mode(to the default value) at > least once. It may not be a requirement for Taal, but if that's the > case, why did we have a set_addr_mode() call in taal_power_on() in the > first place? Is it because we can prepare rotation and mirroring before > we enable the panel?
The panel resets its registers at HW reset, so in case we have changed the rotation or mirroring, we need to set the addr more at power_on to keep the user's rotation and mirroring after resuming from blanking. But now that the rotation or mirroring is never changed, the default value is always fine. Tomi
Description: OpenPGP digital signature