On Sun, Jul 28, 2013 at 7:13 PM, Alexander Holler <[email protected]> wrote:
> Having a quick look git grep gpio_to_irq, I've quickly spotted e.g. this
> in drivers/input/keyboard/gpio_keys.c:
>
> irq = gpio_to_irq(button->gpio);
> if (irq < 0) {
>
> (again <0 not <=0)
Hm I think this should atleast be augmented to spit a warning if
IRQ 0 is returned.
> Besides that, I feel free to ignore me. I don't know what the new
> patches do fix and I don't really have a need for a solution.
No one shall be ignored because I expect the OMAP GPIO
maintainers to have very clear answers to how they want to
proceed with this, and the issue with gpio_to_irq() *is* complex
so we shall indeed discuss it. Better to have the discussion
now and not when it gets deployed in a million systems.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
