On Mon, Nov 23, 1998 at 06:23:41PM +0000, Nick Phillips wrote:
> Linux Lists wrote:
> >
> > Hello,
> >
> > Quick question: does someone have a URL pointing to the description of the
> > PPP 2.3.5 typo problem (instead of LINUX_VERSION_CODE >= , should be
> > LINUX_VERSION_CODE <= , or something on this line ...) ??
>
> It's *not* a typo; it's just that the 2.0.35 kernel moved to the same
> form of call to dev_kfree_skb that the recent 2.1.xx kernels use, and
> the logic in the ppp.c file can't deal with this (2.0.35 didn't exist
> when it was written).
Interesting.
My ancient 1.2.13 kernel tree defines dev_kfree_skb()
(in (source tree)/include/linux/skbuff.h):
extern void dev_kfree_skb(struct sk_buff *skb, int mode);
This is the same definition found in 2.0.34 and 2.0.36. No change
at 2.0.35.
It would be peculiar indeed if the 1.2 definition carried forward to
sometime in the beginning of 2.0, followed by a single-argument
definition, followed by changing to two arguments sometime in 2.1,
and also reverting 2.0 to the 1.2 behavior late in 2.0.
Several other references in the kernel allude to a single change,
in the 2.1 series. For example, the up-to-date drivers/net/3c59x.c
declares:
#if LINUX_VERSION_CODE < 0x20159
#define DEV_FREE_SKB(skb) dev_kfree_skb (skb, FREE_WRITE);
#else /* Grrr, unneeded incompatible change. */
#define DEV_FREE_SKB(skb) dev_kfree_skb(skb);
#endif
(meaning this file thinks there was a change at 2.1.59)
and in drivers/net/tulip.c:
#if (LINUX_VERSION_CODE > 0x20155)
dev_kfree_skb(tp->tx_skbuff[entry]);
#else
dev_kfree_skb(tp->tx_skbuff[entry], FREE_WRITE);
#endif
The cutpoint isn't unanimous, but the verdict seems to be that
the number of arguments changed once, sometime in 2.1, and
has never changed in 2.0.
Of course, empirical evidence from the source trees _might_
contradict this.
Anybody got a collection of kernel sources online, where they
could look at (source tree root)/include/linux/skbuff.h from a
variety of 2.0 and 2.1 versions?
Absent that, it appears that linux/ppp.c does indeed have a simple typo.
--
Dan Wilder <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to [EMAIL PROTECTED]
