On Tue, Oct 20, 2015 at 6:00 PM, Sagi Grimberg <[email protected]> wrote:
>> (2) re this one, as I wrote in the past, I am in favor of simple >> caching of struct ib_device_attr on struct ib_device (best with pointer) and >> not adding >> 333 fields to struct ib_device, I don't see the benefit from this patch. > Christoph commented on that: > > "I'm strongly against this. As the reviews show the move is highly > confusing. The attributes don't change and there is no need to 'cache' > or 'query' them. Just merge them into the device, follow years of > experience with how every other Linux subsystem does it and be done > with it." > > If the attributes are automatically a part of the ib_device then it > does seem a bit redundant keeping the structure around... But this makes struct ib_device much much bigger, and this structure is used in **fast** path, e.g the ULP traverses through a pointer from struct ib_device to post_send/recv, poll_cq and friends. The networking community will let you work for 10y before they add a field to struct net_device exactly b/c of the reason I brought. Why here we can come out of the blue and add tens if not hundreds of fields to our device structure? Or. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
