On 10/21/2015 10:33 AM, Christoph Hellwig wrote:
For anything you want to add you need to touch_a_ struct. It's not any
difference in efforts if it's ib_device_attr or ib_device.
You're not even saving much memory if at all as every driver caches at
least some fields of it in their own device structure, and iser, isert,
srpt and nfs cache the full structure,
I know, but a patch that adds caching an attr pointer on the device will
remove these local caches,
we actually had that/similar patch posted here and it was dropped/forgotten.
so if you use one of those you're
already having one of them per device. If you use two of them you
have multiple copies plus individual fields caches by other ULDs and core
code.
again, the method I propose does remove these duplications all together.
I am still waiting to hear what is the precise argument for having this
change.
Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html