> +#define MLX4_MAC_HEAD 0x2c9000000ULL > + random_ether_addr(rand_mac); > + caps->def_mac[i] = MLX4_MAC_HEAD | rand_mac[0] | > + ((u64)(rand_mac[1]) << 8) | ((u64)(rand_mac[2]) > << 16);
Is this a good idea? You're basically choosing 24 random bits within your OUI... seems the chance of collision with another MAC used on the same network is high enough that it could easily happen in practice on a moderately big network. Can you pick a reserved range or something? Also I'm not sure if there's much point in using random_ether_addr if you're going to override the high order part anyway, since random_ether_addr just makes sure it doesn't pick a multicast address. - R. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
