On Thu, Nov 05, 2009 at 07:58:12AM -0800, Roland Dreier wrote: > > > This approach seems to be common practice now (e.g., > drivers/net/igb/igb_main.c:1332). > > In any case, the user can change the randomized mac. > > igb uses the full output of random_ether_addr(). I'd be fine with > that. However setting the OUI means you only get 24 bits of randomness > which makes a collision a lot more likely.
IIRC that was precisely why the OUI isn't used for the igb driver. Perhaps some infrastructure (by which I mean a random_mac() function) is warranted so at least this discussion can be concentrated around that rather than repeating it for each driver that needs random mac addresses. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
