Thanks for pointing out the bug.  

>       /* Remap the PCI registers in adapter BAR0 to kernel VA space */
>-      mmio_regs = ioremap_nocache(pci_resource_start(pcidev, BAR_0), 
>sizeof(mmio_regs));
>+      mmio_regs = ioremap_nocache(pci_resource_start(pcidev, BAR_0),
>+                                  sizeof(*mmio_regs));
>       if (mmio_regs == NULL) {
>               printk(KERN_ERR PFX "Unable to remap BAR0\n");
>               ret = -EIO;

mmio_regs is initialized to NULL at the top of the function so *mmio_regs 
wouldn't be
a good idea.  Instead of sizeof(*mmio_regs) use pci_resource_len(pcidev, 
BAR_0).  If
you can recreate the patch with this change I will ack it.

Thanks,


Chien


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to