>From: Julia Lawall <[email protected]>
>
>The size argument to ioremap_nocache should be the size of desired
>information, not the pointer to it.
>
>The semantic match that finds this problem is as follows:
>(http://coccinelle.lip6.fr/)
>
>// <smpl>
>@expression@
>expression *x;
>@@
>
>x =
> <+...
>*sizeof(x)
>...+>// </smpl>
>
>Signed-off-by: Julia Lawall <[email protected]>
>
>---
> drivers/infiniband/hw/nes/nes.c     |    3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/infiniband/hw/nes/nes.c b/drivers/infiniband/hw/nes/nes.c
>index cbde0cf..95db98f 100644
>--- a/drivers/infiniband/hw/nes/nes.c
>+++ b/drivers/infiniband/hw/nes/nes.c
>@@ -521,7 +521,8 @@ static int __devinit nes_probe(struct pci_dev *pcidev, 
>const struct pci_device_i
>       spin_lock_init(&nesdev->indexed_regs_lock);
>
>       /* Remap the PCI registers in adapter BAR0 to kernel VA space */
>-      mmio_regs = ioremap_nocache(pci_resource_start(pcidev, BAR_0), 
>sizeof(mmio_regs));
>+      mmio_regs = ioremap_nocache(pci_resource_start(pcidev, BAR_0),
>+                                  pci_resource_len(pcidev, BAR_0));
>       if (mmio_regs == NULL) {
>               printk(KERN_ERR PFX "Unable to remap BAR0\n");
>               ret = -EIO;

Acked-by: Chien Tung <[email protected]>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to