>> +int mlx4_bitmap_init_no_mask(struct mlx4_bitmap *bitmap, u32 num,
>> + u32 reserved_bot, u32 reserved_top)
>> +{
>> + u32 num_rounded = roundup_pow_of_two(num);
>> + return mlx4_bitmap_init(bitmap, num_rounded, num_rounded - 1,
>> + reserved_bot, num_rounded - num + reserved_top);
>> +}
>
> I think I would really prefer things if we got rid of this wrapper. The
> mlx4_bitmap stuff is really there to handle the case where we want to have a
> mask and have the non-used bits cycle to avoid reusing QPN etc.
> If we have a bitmap with no mask that's no a power of 2 in size, there's
> really no value in the mlx4 wrapper -- we might as well just allocate a
> bitmap > directly.
>
> And since this is only used in one place (for the EQ tables) I think it makes
> sense to just open-code everything in the EQ code.
I am preparing a new set of patches for SRIOV support, this change will be
included--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
