On Sat, Oct 23, 2010 at 12:00:59AM -0700, Hefty, Sean wrote:
> The only definitions for MAD data types are in ib_types.h, which
> is an opensm file. The libibumad interface is essentially useless
> without these data types. Add new header files to libibumad
> with basic MAD data types.
This is nice, lots of work! Wow!
> +/* Management base version */
> +#define UMAD_BASE_VERSION 1
Could you elaborate in the comment what you see this being used for?
> +struct umad_hdr {
Could we agree on a naming scheme? I was thinking umad_hdr_NE or
somesuch to identify these all as network endian. It is actually
pretty confusing in someplaces what is what. Ie for instance the
ibv_sa_path_rec is unpacked but in network endian, while things
like ibv_ah_attrs are in host endian. I've made errors getting this
right before (partly because there are no docs..)
> +#define UMAD_OPENIB_OUI (0x001405)
Enum?
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
