> > +/* Management base version */
> > +#define UMAD_BASE_VERSION 1
>
> Could you elaborate in the comment what you see this being used for?
The comment should just go. This is copy-paste from the kernel headers.
> > +struct umad_hdr {
>
> Could we agree on a naming scheme? I was thinking umad_hdr_NE or
> somesuch to identify these all as network endian. It is actually
> pretty confusing in someplaces what is what. Ie for instance the
> ibv_sa_path_rec is unpacked but in network endian, while things
> like ibv_ah_attrs are in host endian. I've made errors getting this
> right before (partly because there are no docs..)
maybe we should define net16/be16, etc. data types, similar to the kernel and
ib_types?
> > +#define UMAD_OPENIB_OUI (0x001405)
>
> Enum?
sure - unless someone can think of a reason why that wouldn't work
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
