On 6/16/2011 2:10 PM, Ira Weiny wrote:
> -             printf("MCMemberRecord member dump:\n"
> -                    "\t\tMGID....................%s\n"
> -                    "\t\tMlid....................0x%X\n"
> -                    "\t\tPortGid.................%s\n"
> -                    "\t\tScopeState..............0x%X\n"
> -                    "\t\tProxyJoin...............0x%X\n"
> -                    "\t\tNodeDescription.........%s\n",
> -                    inet_ntop(AF_INET6, p_mcmr->mgid.raw, gid_str,
> -                              sizeof gid_str),
> -                    cl_ntoh16(p_mcmr->mlid),
> -                    inet_ntop(AF_INET6, p_mcmr->port_gid.raw,
> -                              gid_str2, sizeof gid_str2),
> -                    p_mcmr->scope_state, p_mcmr->proxy_join, node_name);
> +             dump_one_mcmember_record(data);

This will print more info per MC member with much of it (group related)
repeated. Is there some need for the additional info or is this just for
code reuse ? If it's the latter, I would prefer to not see it change or
add an additional parameter to dump_one_mcmember_record as to the
specific fields to print.

-- Hal

> +             printf("\t\tNodeDescription.........%s\n", node_nam

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to