On Wed, Oct 19, 2011 at 7:38 PM, Nicholas A. Bellinger <[email protected]> wrote: > Btw, Roland asked me to take a look at the current set of module > parameters for ib_srpt, and see which could be removed and/or converted > to per SPR target endpoint configfs attributes.. So on that note, a few > questions for you on a couple of the module parameters: > > *) use_port_guid_in_session_name: This appears to be a legacy compat > item, can this be safetly removed for mainline..?
As far as I know some people are still using this parameter. > *) srpt_service_guid: Should this really have global scope..? I'm afraid that having different values of this parameter for different HCAs would break failing over between HCAs. > Aside from those, i'm currently having a look to see which of the module > parameters are not used in the initial srpt_add_one() setup path, and > that using per SRP target endpoint configfs attributes would make sense. My opinion is that the parameters used in srpt_add_one() also should be converted from module parameters into something that is configurable dynamically. ib_srpt users have already been asking to make e.g. srp_max_req_size configurable dynamically. It should be doable to reallocate the receive ring when there are no active sessions. Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
