On Oct 17, 2011, at 5:28 PM, Hal Rosenstock wrote: > > A couple of minor comments: > > 1. Why not move the OSM_EVENT_ID_LIGHT_SWEEP_DONE event to where "LIGHT > SWEEP COMPLETE" is indicated in osm_state_mgr.c ? That's actually more > accurate as all the transactions have completed. > > 2. The new events should be added to osmeventplugin/src/osmeventplugin.c > example. > > Thanks. > > -- Hal >
Thanks for the comments. The attached osm_light_sweep.patch addresses the points above by moving the OSM_EVENT_ID_LIGHT_SWEEP_DONE event to be with it's corresponding LIGHT SWEEP COMPLETE log message. Also, the light sweep START/DONE events are included in the example event plugin. While adding to the example event plugin, I realized that the autoconf setup in 3.3.9 does not appear to be propagating all user settings down into the default plugin. Consequently, I was not able to build the plugin when OFED headers were not in the default location. In case it's useful (and hasn't already been addressed), the second attached patch adds $(OSMV_INCLUDES) to the automake directives for the plugin which was sufficient in my case to resolve necessary headers. Thanks, Karl
osm_light_sweep.patch
Description: osm_light_sweep.patch
build.patch
Description: build.patch
