Le lundi 06 février 2012 à 17:05 +0200, Or Gerlitz a écrit : > On 2/3/2012 10:24 PM, Hefty, Sean wrote: > >> Hmm... a tcpdump would help to understand what is going on (for example if > >> GRO kicks in) > > > > I should stop trying to apply patches so late. I must have done something > > wrong with my quick test. Re-applying the patch on 3.2, the ipoib UD > > performance looks okay to me with Eric's patch. Sorry about the flub. > > > > Sean, same here, with both 3.2 and 3.3-rc1 I see with tcpdump that no > GRO aggregation is done in the receiving side, when applying the patch I > sent (Eric's patch enhanced to change ipoib code such that it sets > gro_mac_header_lento the ipoib header len), I can see GRO aggregation > and the performance goes well up. So how do we go from here? Herbert, > Roland, are you okay with the patch? > > Eric, if this we're going on that patch, could you please add > Reported-by: Shlomo Pongratz <[email protected]> to the change-log.
Sure, I suggest two patches then. One from me (the one I sent earlier), introducing the core infrastructure, and one from you adding the "dev->gro_mac_header_len = IPOIB_ENCAP_LEN;" in drivers/infiniband/ulp/ipoib/ipoib_main.c If you agree, I'll resend my part with official submission, and you'll send your patch after ? -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
