From: Eric Dumazet <[email protected]> Date: Mon, 06 Feb 2012 17:27:07 +0100
> Shlomo Pongratz reported GRO L2 header check was suited for Ethernet > only, and failed on IB/ipoib traffic. > > He provided a patch faking a zeroed header to let GRO aggregates frames. > > Roland Dreier, Herbert Xu, and others suggested we change GRO L2 header > check to be more generic. > > This patch introduces a new netdevice field, gro_mac_header_len, giving > L2 header length, default to ETH_HLEN (14 bytes) > > A device setup function can override this default value. > > __napi_gro_receive() has special handling for the common case (Ethernet) > to avoid a memcmp() call and use an inline optimized function instead. > > Signed-off-by: Eric Dumazet <[email protected]> > Reported-by: Shlomo Pongratz <[email protected]> We really need an explanation, probably both in the commit message and the comments next to this new struct member, explaining why in the world we can't use ->hard_header_len for this. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
