From: Or Gerlitz <[email protected]> Date: Wed, 8 Feb 2012 23:08:26 +0200
> On Wed, Feb 8, 2012 at 10:50 PM, David Miller <[email protected]> wrote: >> From: Eric Dumazet <[email protected]> >> > Shlomo Pongratz reported GRO L2 header check was suited for Ethernet >> > only, and failed on IB/ipoib traffic. >> > He provided a patch faking a zeroed header to let GRO aggregates frames. >> > >> > Roland Dreier, Herbert Xu, and others suggested we change GRO L2 header >> > check to be more generic, ie not assuming L2 header is 14 bytes, but >> > taking into account hard_header_len. >> > >> > __napi_gro_receive() has special handling for the common case (Ethernet) >> > to avoid a memcmp() call and use an inline optimized function instead. > >> Applied. > > Hi Dave, for correct operation / future bisection, you should 1st > apply Roland's patch which reduces the hard header len advertized by > ipoib to be only the size of the ipoib header without that 20 bytes > headroom, else the gro memcmp will be issued on the ipoib header and > then 20 bytes of the ip header, kind of back to square one... I did. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
