On Mon, 2013-07-01 at 10:49 -0700, Roland Dreier wrote:
> So I'm inclined to apply the mlx5 driver for 3.11, since it's a
> completely new driver. However, reading through it so far I had the
> following comments, and I'd like these cleanups addressed along with
> Dave Miller's:
>
> - The debug mask complexity seems unnecessary now that pr_debug() is
> controllable at runtime with the DYNAMIC_DEBUG stuff. We should get
> rid of the extra level of indirection.
There's some value in block enabling/disabling messages
that dynamic_debug doesn't currently offer.
> - In:
>
> +struct mlx5_cmd {
> ...
> + struct mlx5_cmd_stats stats[0x80a];
>
> the 0x80a magic number really needs to have a name.
And that's a pretty big struct too.
2058 array entries. ~100kb
Does it really need to be that big?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
