On 07/03/13 16:08, David Dillow wrote:
On Wed, 2013-07-03 at 14:55 +0200, Bart Van Assche wrote:
Finish all outstanding I/O requests after fast_io_fail_tmo expired,
which speeds up failover in a multipath setup. This patch is a
reworked version of a patch from Sebastian Riemer.
Reported-by: Sebastian Riemer <[email protected]>
Signed-off-by: Bart Van Assche <[email protected]>
Acked-by: David Dillow <[email protected]>
I don't believe I ack'd this; I don't want the callers doing the result
shift, do it in srp_finish_req().
My apologies. You are correct, this patch was not yet acknowledged by you.
Regarding the shift itself: is it really that important whether the
caller or callee performs that shift ? Having it in the caller has the
advantage that the compiler can optimize the shift operation out because
the number that is being shifted left is a constant. And if later on it
would be necessary to set more fields of the SCSI result in a caller of
srp_finish_req() then that will be possible without having to modify the
srp_finish_req() function itself.
Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
