On Wed, 2013-07-03 at 10:57 -0400, David Dillow wrote: > On Wed, 2013-07-03 at 16:45 +0200, Bart Van Assche wrote: > > Having it in the caller has the > > advantage that the compiler can optimize the shift operation out because > > the number that is being shifted left is a constant. > > srp_finish_req() is likely to be inlined, so the compiler will be able > to make this optimization. Regardless, this is so far in the noise that > it looses to readability.
Eh, just leave it alone. As much as I don't like it, it does look to be fairly common among the LLDs and other transport code. Acked-by: David Dillow <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
