On Wed, Feb 25, 2015 at 06:13:35PM +0000, Weiny, Ira wrote:
> > > diff --git a/drivers/infiniband/core/mad.c
> > > b/drivers/infiniband/core/mad.c index 819b794..a6a33cf 100644
> > > +++ b/drivers/infiniband/core/mad.c
> > > @@ -2924,6 +2924,12 @@ static int ib_mad_port_open(struct ib_device
> > *device,
> > > char name[sizeof "ib_mad123"];
> > > int has_smi;
> > >
> > > + if (device->cached_dev_attrs.max_mad_size < IB_MGMT_MAD_SIZE) {
> > > + dev_err(&device->dev, "Min MAD size for device is %u\n",
> > > + IB_MGMT_MAD_SIZE);
> > > + return -EFAULT;
> > > + }
> > > +
> >
> > The printk message here is not very informative and it qualifies as an
> > error.
> > Someone reading that for the first time in the dmesg output and wondering
> > why their device isn't working will be confused if they don't know about the
> > mad size changes you are making here. Something like "max supported MAD
> > size (%u) < min required by ib_mad (%u), ignoring dev \n"
>
> Good suggestion.
>
> Fixed for v5 with this message.
>
> + dev_err(&device->dev,
> + "Max supported MAD size (%u) < min required by ib_mad
> (%u), ignoring device (%s)\n",
> + device->cached_dev_attrs.max_mad_size,
> + IB_MGMT_MAD_SIZE, device->name);
It also seems redundant since the only call to ib_mad_port_open is:
if (ib_mad_port_open(device, i)) {
printk(KERN_ERR PFX "Couldn't open %s port %d\n",
device->name, i);
So, why does this particular error deserve a special double error
print? I assume it is basically impossible to hit?
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
