On Wed, Feb 25, 2015 at 06:32:27PM +0000, Weiny, Ira wrote:
> > >
> > > Fixed for v5 with this message.
> > >
> > > + dev_err(&device->dev,
> > > + "Max supported MAD size (%u) < min required by
> > > ib_mad
> > (%u), ignoring device (%s)\n",
> > > + device->cached_dev_attrs.max_mad_size,
> > > + IB_MGMT_MAD_SIZE, device->name);
> >
> > It also seems redundant since the only call to ib_mad_port_open is:
> >
> > if (ib_mad_port_open(device, i)) {
> > printk(KERN_ERR PFX "Couldn't open %s port %d\n",
> > device->name, i);
> >
> > So, why does this particular error deserve a special double error print? I
> > assume it is basically impossible to hit?
>
> This does indicate a coding error. Generally I prefer details of
> why the device could not open the port. But if the community feels
> this is redundant or "not possible" I can drop the hunk.
Internal logic errors are handled with WARN_ON/BUG/etc.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
