On Thu, Dec 24, 2015 at 10:02:29AM +0200, Or Gerlitz wrote:
> We had consensus among the reviewers that the 1st patch ("IB/core: Align
> coding style of ib_device_cap_flags structure") is wrong cleanup which
> basically is (1) unneeded (2) creates more damage (git blame and such,
> non-applicable to uapi, more) than benefit, etc -- finally Leon was
> convinced too [1].It's not really an issue vs uapi. Using the the wierd BIT() macro would have been, but without it I think this cleanup is ok, even if I personally wouldn't have done it. git-blame isn't really a major issue either, as you can blame past revisions. > Leon will re-spin in the coming 1-2 hours V2, could please pick it instead > of V1, when people agree on direction X and you are not against it, lets do > X and not Y. It would be great if we could stop rebasing whats already in the tree for the benefit of everyone building on top of this. For example just finished rebasing my series to move many constants includin this one to the uapi headers, and I'd hate to rebase it once again now that the dust has settled. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
