On 14 October 2016 at 15:18, Chris Brandt <chris.bra...@renesas.com> wrote:
> On 9/22/2016, Ulf Hansson wrote:
>> To: Chris Brandt <chris.bra...@renesas.com>
>> Cc: Wolfram Sang <wsa+rene...@sang-engineering.com>; Sergei Shtylyov
>> <sergei.shtyl...@cogentembedded.com>; Geert Uytterhoeven <geert@linux-
>> m68k.org>; Simon Horman <horms+rene...@verge.net.au>; linux-mmc <linux-
>> m...@vger.kernel.org>; Linux-Renesas <email@example.com>;
>> Lee Jones <l...@kernel.org>
>> Subject: Re: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port
>> + Lee
>> On 12 September 2016 at 16:15, Chris Brandt <chris.bra...@renesas.com>
>> > For the r7s72100 SOC, the DATA_PORT register was changed to 32-bits wide.
>> > Therefore a new flag has been created that will allow 32-bit
>> > reads/writes to the DATA_PORT register instead of 16-bit (because
>> > 16-bits accesses are not supported).
>> > Signed-off-by: Chris Brandt <chris.bra...@renesas.com>
>> > ---
>> > v3:
>> > * changed loops to memcpy
>> > v2:
>> > * changed 'data * 0xFF' to 'data & 0xFF'
>> > * added 'const' for sd_ctrl_write32_rep
>> > ---
>> > drivers/mmc/host/tmio_mmc.h | 12 ++++++++++++
>> > drivers/mmc/host/tmio_mmc_pio.c | 30 ++++++++++++++++++++++++++++++
>> > include/linux/mfd/tmio.h | 5 +++++
>> This header file needs to be split up. The mmc specific bits, should be
>> moved to a local header file under driver/mmc/host/*.
>> Sure, we don't need to do that as part of $subject patch, but then I need
>> an ack from Lee Jones, the mfd maintainer. I have added him on cc.
> Is this still waiting on an ACK from Lee Jones because it touches the tmio.h
> file under include/linux/mfd/ ?
Yes, but more important is Wolfram's ack as he maintains