Hi Kieran, Thank you for the patch.
On Wednesday 08 Feb 2017 14:03:57 Kieran Bingham wrote: > From: Kieran Bingham <[email protected]> > > Parameters can contain characters not suited to use in filenames. > > Add '=','(', and ')' to the filtering, and replace with '_' What's the issue with those characters ? :-) > Signed-off-by: Kieran Bingham <[email protected]> > --- > scripts/vsp-lib.sh | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/scripts/vsp-lib.sh b/scripts/vsp-lib.sh > index 5aff30217a27..08bf8f36c582 100755 > --- a/scripts/vsp-lib.sh > +++ b/scripts/vsp-lib.sh > @@ -263,6 +263,9 @@ compare_frames() { > local params=${args// /-} > params=${params:+-$params} > params=${params//\//_} > + params=${params/=/_} > + params=${params/(/_} > + params=${params/)/_} According to the bash manpage, "If pattern begins with /, all matches of pattern are replaced with string. Normally only the first match is replaced." Shouldn't you add a leading / as for the \/ substitution ? > params=$in_fmt-$out_fmt-$size$params > > if [ x$__vsp_pixel_perfect != xtrue ] ; then -- Regards, Laurent Pinchart
