Hi Kieran, Thank you for the patch.
On Wednesday 08 Feb 2017 14:03:56 Kieran Bingham wrote: > From: Kieran Bingham <[email protected]> > > In the event of failed frames, or VSP_KEEP_FRAMES being set, the output > file names do not sort such that the reference frame is next to the > failed frame. > > This can make comparing reference frames and the relevant output frames > tedious and difficult. > > Re-arrange the output filenames such that the sort order will match the > option parameters correctly, followed by either the reference frame > identifier, or the frame number at the end of the filename string > > Signed-off-by: Kieran Bingham <[email protected]> Reviewed-by: Laurent Pinchart <[email protected]> and pushed. > --- > scripts/vsp-lib.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/scripts/vsp-lib.sh b/scripts/vsp-lib.sh > index 1a356ec02374..5aff30217a27 100755 > --- a/scripts/vsp-lib.sh > +++ b/scripts/vsp-lib.sh > @@ -278,12 +278,12 @@ compare_frames() { > } > > if [ $match = "false" -o x$VSP_KEEP_FRAMES = x1 ] ; then > - mv $frame ${0/.sh/}-$(basename ${frame/.bin/-$params.bin}) > + mv $frame ${0/.sh/}-$params-$(basename ${frame}) > fi > done > > if [ x$VSP_KEEP_FRAMES = x1 -o $result = "fail" ] ; then > - mv ${frames_dir}ref-frame.bin ${0/.sh/}-ref-frame-$params.bin > + mv ${frames_dir}ref-frame.bin ${0/.sh/}-$params-ref-frame.bin > else > rm -f ${frames_dir}ref-frame.bin > rm -f ${frames_dir}frame-*.bin -- Regards, Laurent Pinchart
