Hi Uli,
On Wed, Apr 19, 2017 at 3:24 PM, Ulrich Hecht
<[email protected]> wrote:
> From: Takeshi Kihara <[email protected]>
>
> This patch adds PWM{0,1,2,3,4,5,6} device nodes for R8A7796 SoC.
>
> Signed-off-by: Takeshi Kihara <[email protected]>
> Signed-off-by: Ulrich Hecht <[email protected]>
> ---
> arch/arm64/boot/dts/renesas/r8a7796.dtsi | 63
> ++++++++++++++++++++++++++++++++
> 1 file changed, 63 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> index 798fe0f..578b318 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> @@ -455,6 +455,69 @@
> status = "disabled";
> };
>
> + pwm0: pwm@e6e30000 {
> + compatible = "renesas,pwm-r8a7796",
> "renesas,pwm-rcar";
Please also send a patch to document "renesas,pwm-r8a7796" in the
renesas,pwm-rcar DT bindings.
> + reg = <0 0xe6e30000 0 0x10>;
A length of 8 would be sufficient. Not a big issue due, as ioremap()
granularity
is PAGE_SIZE anyway.
> + #pwm-cells = <2>;
> + clocks = <&cpg CPG_MOD 523>;
> + power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
Missing "resets = <&cpg 523>;"
> + status = "disabled";
> + };
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
