From: Takeshi Kihara <[email protected]>

This patch fixes the implementation incorrect of IPSR register value
definitions for NFDATA{0..13} and NF{ALE,CLE,WE_N,RE_N} pins function.

This is a correction to the incorrect implementation of IPSR register
pin assignment for R8A7796 SoC specification of R-Car Gen3 Hardware
User's Manual Rev.0.51E or later.

Fixes: f9aece7344bd ("pinctrl: sh-pfc: Initial R8A7796 PFC support")
Signed-off-by: Takeshi Kihara <[email protected]>
Signed-off-by: Yoshihiro Kaneko <[email protected]>
---
 drivers/pinctrl/sh-pfc/pfc-r8a7796.c | 36 ++++++++++++++++++------------------
 1 file changed, 18 insertions(+), 18 deletions(-)

diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7796.c 
b/drivers/pinctrl/sh-pfc/pfc-r8a7796.c
index 9a9094f..80007b9 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7796.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7796.c
@@ -291,24 +291,24 @@
 #define IP8_23_20      FM(SD1_DAT1)            FM(SD2_DAT5)    
FM(MSIOF1_TXD_G)        FM(NFDATA14_B)                  F_(0, 0)        
FM(TS_SPSYNC1_B)FM(STP_ISSYNC_1_B)      F_(0, 0)        F_(0, 0)                
F_(0, 0)        F_(0, 0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) 
F_(0, 0)
 #define IP8_27_24      FM(SD1_DAT2)            FM(SD2_DAT6)    
FM(MSIOF1_SS1_G)        FM(NFDATA15_B)                  F_(0, 0)        
FM(TS_SDAT1_B)  FM(STP_ISD_1_B)         F_(0, 0)        F_(0, 0)                
F_(0, 0)        F_(0, 0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) 
F_(0, 0)
 #define IP8_31_28      FM(SD1_DAT3)            FM(SD2_DAT7)    
FM(MSIOF1_SS2_G)        FM(NFRB_N_B)                    F_(0, 0)        
FM(TS_SDEN1_B)  FM(STP_ISEN_1_B)        F_(0, 0)        F_(0, 0)                
F_(0, 0)        F_(0, 0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) 
F_(0, 0)
-#define IP9_3_0                FM(SD2_CLK)             F_(0, 0)        F_(0, 
0)                FM(NFDATA8)                     F_(0, 0)        F_(0, 0)      
  F_(0, 0)                F_(0, 0)        F_(0, 0)                F_(0, 0)      
  F_(0, 0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
-#define IP9_7_4                FM(SD2_CMD)             F_(0, 0)        F_(0, 
0)                FM(NFDATA9)                     F_(0, 0)        F_(0, 0)      
  F_(0, 0)                F_(0, 0)        F_(0, 0)                F_(0, 0)      
  F_(0, 0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
-#define IP9_11_8       FM(SD2_DAT0)            F_(0, 0)        F_(0, 0)        
        FM(NFDATA10)                    F_(0, 0)        F_(0, 0)        F_(0, 
0)                F_(0, 0)        F_(0, 0)                F_(0, 0)        F_(0, 
0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
-#define IP9_15_12      FM(SD2_DAT1)            F_(0, 0)        F_(0, 0)        
        FM(NFDATA11)                    F_(0, 0)        F_(0, 0)        F_(0, 
0)                F_(0, 0)        F_(0, 0)                F_(0, 0)        F_(0, 
0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
-#define IP9_19_16      FM(SD2_DAT2)            F_(0, 0)        F_(0, 0)        
        FM(NFDATA12)                    F_(0, 0)        F_(0, 0)        F_(0, 
0)                F_(0, 0)        F_(0, 0)                F_(0, 0)        F_(0, 
0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
-#define IP9_23_20      FM(SD2_DAT3)            F_(0, 0)        F_(0, 0)        
        FM(NFDATA13)                    F_(0, 0)        F_(0, 0)        F_(0, 
0)                F_(0, 0)        F_(0, 0)                F_(0, 0)        F_(0, 
0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
-#define IP9_27_24      FM(SD2_DS)              F_(0, 0)        F_(0, 0)        
        FM(NFALE)                       F_(0, 0)        F_(0, 0)        F_(0, 
0)                F_(0, 0)        FM(SATA_DEVSLP_B)       F_(0, 0)        F_(0, 
0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
-#define IP9_31_28      FM(SD3_CLK)             F_(0, 0)        F_(0, 0)        
        FM(NFWE_N)                      F_(0, 0)        F_(0, 0)        F_(0, 
0)                F_(0, 0)        F_(0, 0)                F_(0, 0)        F_(0, 
0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
-#define IP10_3_0       FM(SD3_CMD)             F_(0, 0)        F_(0, 0)        
        FM(NFRE_N)                      F_(0, 0)        F_(0, 0)        F_(0, 
0)                F_(0, 0)        F_(0, 0)                F_(0, 0)        F_(0, 
0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
-#define IP10_7_4       FM(SD3_DAT0)            F_(0, 0)        F_(0, 0)        
        FM(NFDATA0)                     F_(0, 0)        F_(0, 0)        F_(0, 
0)                F_(0, 0)        F_(0, 0)                F_(0, 0)        F_(0, 
0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
-#define IP10_11_8      FM(SD3_DAT1)            F_(0, 0)        F_(0, 0)        
        FM(NFDATA1)                     F_(0, 0)        F_(0, 0)        F_(0, 
0)                F_(0, 0)        F_(0, 0)                F_(0, 0)        F_(0, 
0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
-#define IP10_15_12     FM(SD3_DAT2)            F_(0, 0)        F_(0, 0)        
        FM(NFDATA2)                     F_(0, 0)        F_(0, 0)        F_(0, 
0)                F_(0, 0)        F_(0, 0)                F_(0, 0)        F_(0, 
0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
-#define IP10_19_16     FM(SD3_DAT3)            F_(0, 0)        F_(0, 0)        
        FM(NFDATA3)                     F_(0, 0)        F_(0, 0)        F_(0, 
0)                F_(0, 0)        F_(0, 0)                F_(0, 0)        F_(0, 
0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
-#define IP10_23_20     FM(SD3_DAT4)            FM(SD2_CD_A)    F_(0, 0)        
        FM(NFDATA4)                     F_(0, 0)        F_(0, 0)        F_(0, 
0)                F_(0, 0)        F_(0, 0)                F_(0, 0)        F_(0, 
0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
-#define IP10_27_24     FM(SD3_DAT5)            FM(SD2_WP_A)    F_(0, 0)        
        FM(NFDATA5)                     F_(0, 0)        F_(0, 0)        F_(0, 
0)                F_(0, 0)        F_(0, 0)                F_(0, 0)        F_(0, 
0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
-#define IP10_31_28     FM(SD3_DAT6)            FM(SD3_CD)      F_(0, 0)        
        FM(NFDATA6)                     F_(0, 0)        F_(0, 0)        F_(0, 
0)                F_(0, 0)        F_(0, 0)                F_(0, 0)        F_(0, 
0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
-#define IP11_3_0       FM(SD3_DAT7)            FM(SD3_WP)      F_(0, 0)        
        FM(NFDATA7)                     F_(0, 0)        F_(0, 0)        F_(0, 
0)                F_(0, 0)        F_(0, 0)                F_(0, 0)        F_(0, 
0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
-#define IP11_7_4       FM(SD3_DS)              F_(0, 0)        F_(0, 0)        
        FM(NFCLE)                       F_(0, 0)        F_(0, 0)        F_(0, 
0)                F_(0, 0)        F_(0, 0)                F_(0, 0)        F_(0, 
0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
+#define IP9_3_0                FM(SD2_CLK)             F_(0, 0)        
FM(NFDATA8)             F_(0, 0)                        F_(0, 0)        F_(0, 
0)        F_(0, 0)                F_(0, 0)        F_(0, 0)                F_(0, 
0)        F_(0, 0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
+#define IP9_7_4                FM(SD2_CMD)             F_(0, 0)        
FM(NFDATA9)             F_(0, 0)                        F_(0, 0)        F_(0, 
0)        F_(0, 0)                F_(0, 0)        F_(0, 0)                F_(0, 
0)        F_(0, 0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
+#define IP9_11_8       FM(SD2_DAT0)            F_(0, 0)        FM(NFDATA10)    
        F_(0, 0)                        F_(0, 0)        F_(0, 0)        F_(0, 
0)                F_(0, 0)        F_(0, 0)                F_(0, 0)        F_(0, 
0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
+#define IP9_15_12      FM(SD2_DAT1)            F_(0, 0)        FM(NFDATA11)    
        F_(0, 0)                        F_(0, 0)        F_(0, 0)        F_(0, 
0)                F_(0, 0)        F_(0, 0)                F_(0, 0)        F_(0, 
0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
+#define IP9_19_16      FM(SD2_DAT2)            F_(0, 0)        FM(NFDATA12)    
        F_(0, 0)                        F_(0, 0)        F_(0, 0)        F_(0, 
0)                F_(0, 0)        F_(0, 0)                F_(0, 0)        F_(0, 
0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
+#define IP9_23_20      FM(SD2_DAT3)            F_(0, 0)        FM(NFDATA13)    
        F_(0, 0)                        F_(0, 0)        F_(0, 0)        F_(0, 
0)                F_(0, 0)        F_(0, 0)                F_(0, 0)        F_(0, 
0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
+#define IP9_27_24      FM(SD2_DS)              F_(0, 0)        FM(NFALE)       
        F_(0, 0)                        F_(0, 0)        F_(0, 0)        F_(0, 
0)                F_(0, 0)        FM(SATA_DEVSLP_B)       F_(0, 0)        F_(0, 
0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
+#define IP9_31_28      FM(SD3_CLK)             F_(0, 0)        FM(NFWE_N)      
        F_(0, 0)                        F_(0, 0)        F_(0, 0)        F_(0, 
0)                F_(0, 0)        F_(0, 0)                F_(0, 0)        F_(0, 
0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
+#define IP10_3_0       FM(SD3_CMD)             F_(0, 0)        FM(NFRE_N)      
        F_(0, 0)                        F_(0, 0)        F_(0, 0)        F_(0, 
0)                F_(0, 0)        F_(0, 0)                F_(0, 0)        F_(0, 
0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
+#define IP10_7_4       FM(SD3_DAT0)            F_(0, 0)        FM(NFDATA0)     
        F_(0, 0)                        F_(0, 0)        F_(0, 0)        F_(0, 
0)                F_(0, 0)        F_(0, 0)                F_(0, 0)        F_(0, 
0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
+#define IP10_11_8      FM(SD3_DAT1)            F_(0, 0)        FM(NFDATA1)     
        F_(0, 0)                        F_(0, 0)        F_(0, 0)        F_(0, 
0)                F_(0, 0)        F_(0, 0)                F_(0, 0)        F_(0, 
0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
+#define IP10_15_12     FM(SD3_DAT2)            F_(0, 0)        FM(NFDATA2)     
        F_(0, 0)                        F_(0, 0)        F_(0, 0)        F_(0, 
0)                F_(0, 0)        F_(0, 0)                F_(0, 0)        F_(0, 
0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
+#define IP10_19_16     FM(SD3_DAT3)            F_(0, 0)        FM(NFDATA3)     
        F_(0, 0)                        F_(0, 0)        F_(0, 0)        F_(0, 
0)                F_(0, 0)        F_(0, 0)                F_(0, 0)        F_(0, 
0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
+#define IP10_23_20     FM(SD3_DAT4)            FM(SD2_CD_A)    FM(NFDATA4)     
        F_(0, 0)                        F_(0, 0)        F_(0, 0)        F_(0, 
0)                F_(0, 0)        F_(0, 0)                F_(0, 0)        F_(0, 
0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
+#define IP10_27_24     FM(SD3_DAT5)            FM(SD2_WP_A)    FM(NFDATA5)     
        F_(0, 0)                        F_(0, 0)        F_(0, 0)        F_(0, 
0)                F_(0, 0)        F_(0, 0)                F_(0, 0)        F_(0, 
0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
+#define IP10_31_28     FM(SD3_DAT6)            FM(SD3_CD)      FM(NFDATA6)     
        F_(0, 0)                        F_(0, 0)        F_(0, 0)        F_(0, 
0)                F_(0, 0)        F_(0, 0)                F_(0, 0)        F_(0, 
0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
+#define IP11_3_0       FM(SD3_DAT7)            FM(SD3_WP)      FM(NFDATA7)     
        F_(0, 0)                        F_(0, 0)        F_(0, 0)        F_(0, 
0)                F_(0, 0)        F_(0, 0)                F_(0, 0)        F_(0, 
0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
+#define IP11_7_4       FM(SD3_DS)              F_(0, 0)        FM(NFCLE)       
        F_(0, 0)                        F_(0, 0)        F_(0, 0)        F_(0, 
0)                F_(0, 0)        F_(0, 0)                F_(0, 0)        F_(0, 
0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
 #define IP11_11_8      FM(SD0_CD)              F_(0, 0)        FM(NFDATA14_A)  
        F_(0, 0)                        FM(SCL2_B)      FM(SIM0_RST_A)  F_(0, 
0)                F_(0, 0)        F_(0, 0)                F_(0, 0)        F_(0, 
0)        F_(0, 0)        F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
 
 /* IPSRx */            /* 0 */                 /* 1 */         /* 2 */         
        /* 3 */                         /* 4 */         /* 5 */         /* 6 */ 
                /* 7 */         /* 8 */                 /* 9 */         /* A */ 
        /* B */         /* C - F */
-- 
1.9.1

Reply via email to