Hi Dirk,
On Wed, Sep 6, 2017 at 12:59 PM, Dirk Behme <[email protected]> wrote:
> On 06.09.2017 12:42, Geert Uytterhoeven wrote:
>> On Wed, Sep 6, 2017 at 12:09 PM, Dirk Behme <[email protected]>
>> wrote:
>>> On 06.09.2017 11:22, Geert Uytterhoeven wrote:
>>>> On Wed, Sep 6, 2017 at 9:05 AM, Dirk Behme <[email protected]>
>>>> wrote:
>>>>> From: Ryo Kataoka <[email protected]>
>>>>>
>>>>> MSIOF Base Address H'E6xx can be accessed by CPU and DMAC.
>>>>> MSIOF Base Address H'E7xx for DMAC was removed from H/W manual.
>>>>>
>>>>> Signed-off-by: Ryo Kataoka <[email protected]>
>>>>> Signed-off-by: Hiromitsu Yamasaki <[email protected]>
>>>>> Signed-off-by: Dirk Behme <[email protected]>
>>>>
>>>> NAKed-by: Geert Uytterhoeven <[email protected]>
>>>>
>>>> The MSIOF Base Address for DMAC was removed only from the R-Car
>>>> Gen2/Gen3
>>>> manuals. It still affects e.g. R-Mobile APE6.
>>>
>>> Do we have a nice run time detection for that?
>>
>> The current driver code just looks at the DTS, cfr. the comment:
>>
>> /* The DMA engine uses the second register set, if present */
>
> Ok, yes, thanks.
>
> So this patch is completely superfluous, even in the BSP, correct?
Correct. But it keeps on popping up, I think this is the third time someone
tried to submit it upstream :-(
> Will drop it for the next round, hoping that it doesn't result in too much
> rebase hassle ;)
OK, thx!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds