> > +   { .compatible = "renesas,sdhi-r8a77965", .data = 
> > &of_rcar_gen3_compatible, },

Do we need this line...

> >     { .compatible = "renesas,rcar-gen3-sdhi", .data = 
> > &of_rcar_gen3_compatible, },

... with this generic fallback in place?

> > @@ -276,6 +277,7 @@ static void 
> > renesas_sdhi_internal_dmac_complete_tasklet_fn(unsigned long arg)
> >     /* generic ones */
> >     { .soc_id = "r8a7795" },
> >     { .soc_id = "r8a7796" },
> > +   { .soc_id = "r8a77965", .revision = "ES1.0" },
> 
> I think we can drop .revision = "ES1.0"
> 
> to be in keeping with 349936fcdaf8 ("mmc: renesas_sdhi_internal_dmac: use
> more generic whitelisting").

Ack.

Attachment: signature.asc
Description: PGP signature

Reply via email to